Repository navigation
Conversation
Cookie headers were split on commas, causing multiple cookies to be parsed as a single cookie. Split on semicolons to preserve each cookie's name and value. Signed-off-by: Hyunwoo Jung <hyunwoojung@kakao.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
RestTestClientwithMockMvc, multiple cookies are incorrectly parsed as a single cookie.For example, sending
Cookie: foo=bar; baz=quxto the following controller results inrequest.getCookies()returning only one cookie namedfoowith the valuebar; baz=qux, instead of two separate cookies:This happens because
MockMvcClientHttpRequestFactorysplits Cookie headers on commas(,).This PR fixes the issue by splitting Cookie headers on semicolons(
;) instead of commas(,), ensuring that each cookie is parsed separately.